Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

no/feide/moria/servlet/AttribsData.java

Error		Line
	Line does not match expected header line of ' *'.	17
	Line has trailing spaces.	17

no/feide/moria/servlet/BackendStatusHandler.java

Error		Line
	Line has trailing spaces.	54
	Line has trailing spaces.	55
	Line has trailing spaces.	64
	Line has trailing spaces.	73
	Missing a Javadoc comment.	74
	')' is preceded with whitespace.	108
	'}' should be on the same line.	111
	'}' should be on the same line.	114
	'}' should be on the same line.	117
	Line has trailing spaces.	123

no/feide/moria/servlet/BackendStatusUser.java

Error		Line
	Missing a Javadoc comment.	34
	Line has trailing spaces.	35
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Line has trailing spaces.	38
	Line has trailing spaces.	41
	Unused @param tag for 'name'.	42
	Unused @param tag for 'password'.	43
	Line has trailing spaces.	51
	Method 'setName' is not designed for extension - needs to be abstract, final or empty.	56
	Line has trailing spaces.	59
	First sentence should end with a period.	60
	Method 'setPassword' is not designed for extension - needs to be abstract, final or empty.	64
	Line has trailing spaces.	67
	First sentence should end with a period.	68
	Method 'setOrganization' is not designed for extension - needs to be abstract, final or empty.	72
	Line has trailing spaces.	75
	First sentence should end with a period.	76
	Method 'setContact' is not designed for extension - needs to be abstract, final or empty.	80
	Expected @param tag for 'contact'.	80
	Line has trailing spaces.	83
	First sentence should end with a period.	84
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	88
	Line has trailing spaces.	91
	First sentence should end with a period.	92
	Method 'getPassword' is not designed for extension - needs to be abstract, final or empty.	96
	Line has trailing spaces.	99
	First sentence should end with a period.	100
	Method 'getOrganization' is not designed for extension - needs to be abstract, final or empty.	104
	Line has trailing spaces.	107
	First sentence should end with a period.	108
	Method 'getContact' is not designed for extension - needs to be abstract, final or empty.	112

no/feide/moria/servlet/FileMonitor.java

Error		Line
	First sentence should end with a period.	25
	Line has trailing spaces.	28
	Line has trailing spaces.	33
	First sentence should end with a period.	34
	Line has trailing spaces.	46
	Expected @throws tag for 'FileNotFoundException'.	50
	Line has trailing spaces.	54
	Line has trailing spaces.	57
	Line has trailing spaces.	58
	Method 'hasChanged' is not designed for extension - needs to be abstract, final or empty.	60
	Line has trailing spaces.	63

no/feide/moria/servlet/InformationServlet.java

Error		Line
	Unused import - javax.servlet.http.HttpServlet.	32
	Line has trailing spaces.	62
	Line has trailing spaces.	107
	Line has trailing spaces.	109
	Line has trailing spaces.	130
	Line has trailing spaces.	135
	Line has trailing spaces.	191
	Name 'o_relevance' must match pattern '^[a-z][a-zA-Z0-9]*$'.	203
	'=' is not followed by whitespace.	203
	Line has trailing spaces.	215
	Line has trailing spaces.	219
	'cast' is not followed by whitespace.	281
	Line has trailing spaces.	288
	Line has trailing spaces.	338

no/feide/moria/servlet/JSPLogIdentifier.java

Error		Line
	Line does not match expected header line of ' * Copyright (c) 2004 UNINETT FAS'.	2

no/feide/moria/servlet/LoginServlet.java

Error		Line
	Line does not match expected header line of ' *'.	3
	Line has trailing spaces.	3
	Line has trailing spaces.	14
	Unused import - javax.servlet.http.HttpServlet.	31
	Line has trailing spaces.	107
	Line is longer than 150 characters.	165
	Line is longer than 150 characters.	228
	Line is longer than 150 characters.	238
	Line is longer than 150 characters.	244
	Line is longer than 150 characters.	277
	Parameter errorType should be final.	304
	Line has trailing spaces.	306
	Line has trailing spaces.	309
	Line has trailing spaces.	313
	Line has trailing spaces.	316
	Line is longer than 150 characters.	318
	Line has trailing spaces.	319
	Line has trailing spaces.	322
	Line is longer than 150 characters.	325
	Line has trailing spaces.	328
	Line has trailing spaces.	330
	Line has trailing spaces.	353
	Line has trailing spaces.	357
	Line is longer than 150 characters.	372
	Line has trailing spaces.	378
	Line has trailing spaces.	380
	Line has trailing spaces.	389
	Line has trailing spaces.	405
	Line has trailing spaces.	416
	Line has trailing spaces.	421
	Line has trailing spaces.	426
	Line has trailing spaces.	428
	Line has trailing spaces.	431
	Line has trailing spaces.	438

no/feide/moria/servlet/LogoutServlet.java

Error		Line
	Name 'defaultRedirectParameterName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	69
	Line has trailing spaces.	113
	'||' should be on a new line.	115
	Line has trailing spaces.	121
	Line has trailing spaces.	180
	Line has trailing spaces.	191
	Line has trailing spaces.	195
	Line has trailing spaces.	197
	Line is longer than 150 characters.	201
	Line is longer than 150 characters.	202

no/feide/moria/servlet/MoriaServlet.java

Error		Line
	Line does not match expected header line of ' *'.	3
	Line has trailing spaces.	3
	Line has trailing spaces.	14
	Line has trailing spaces.	27
	Line has trailing spaces.	37
	Method 'getServletConfig' is not designed for extension - needs to be abstract, final or empty.	43
	Parameter required_parameters should be final.	43
	Expected @param tag for 'required_parameters'.	43
	Name 'required_parameters' must match pattern '^[a-z][a-zA-Z0-9]*$'.	43
	Parameter log should be final.	43
	Expected @param tag for 'log'.	43
	Line has trailing spaces.	63

no/feide/moria/servlet/PictureServlet.java

Error		Line
	Variable 'log' must be private and have accessor methods.	45
	Line has trailing spaces.	46
	Method 'doGet' is not designed for extension - needs to be abstract, final or empty.	64
	Parameter request should be final.	64
	Parameter response should be final.	64
	Expected @throws tag for 'IOException'.	65
	Expected @throws tag for 'ServletException'.	65
	Line has trailing spaces.	66
	Line has trailing spaces.	76
	Line contains a tab character.	76
	Line contains a tab character.	78
	Line has trailing spaces.	83
	Line contains a tab character.	83
	Line contains a tab character.	84
	Line contains a tab character.	85
	Line contains a tab character.	86
	'}' should be on the same line.	86
	Line contains a tab character.	87
	Line contains a tab character.	88
	Line contains a tab character.	90
	Line contains a tab character.	91
	Line contains a tab character.	92
	Line contains a tab character.	93

no/feide/moria/servlet/RequestUtil.java

Error		Line
	Variable 'log' must be private and have accessor methods.	51
	First sentence should end with a period.	247
	Line has trailing spaces.	253
	Line has trailing spaces.	378
	Line is longer than 150 characters.	540

no/feide/moria/servlet/StatisticsCollection.java

Error		Line
	Missing a Javadoc comment.	31
	Line has trailing spaces.	32
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Line has trailing spaces.	34
	Missing a Javadoc comment.	35
	Name 'orgname_in' must match pattern '^[a-z][a-zA-Z0-9]*$'.	35
	Method 'getOrgName' is not designed for extension - needs to be abstract, final or empty.	38
	Missing a Javadoc comment.	38
	Method 'getNumMonths' is not designed for extension - needs to be abstract, final or empty.	41
	Missing a Javadoc comment.	41
	Method 'getMonthName' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44
	Method 'getNumStatisticsData' is not designed for extension - needs to be abstract, final or empty.	48
	Missing a Javadoc comment.	48
	Method 'getStatisticsData' is not designed for extension - needs to be abstract, final or empty.	51
	Missing a Javadoc comment.	51
	Method 'addMonth' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Line has trailing spaces.	68
	First sentence should end with a period.	69
	Line has trailing spaces.	71
	Expected @param tag for 'monthname'.	74
	Line has trailing spaces.	77

no/feide/moria/servlet/StatisticsData.java

Error		Line
	Line has trailing spaces.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Line has trailing spaces.	32
	Missing a Javadoc comment.	34
	Line has trailing spaces.	38
	Method 'setName' is not designed for extension - needs to be abstract, final or empty.	39
	Missing a Javadoc comment.	39
	Line has trailing spaces.	42
	Method 'addMonth' is not designed for extension - needs to be abstract, final or empty.	43
	Missing a Javadoc comment.	43
	'}' should be on the same line.	49
	Line has trailing spaces.	54
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	55
	Missing a Javadoc comment.	55
	Method 'getCount' is not designed for extension - needs to be abstract, final or empty.	58
	Missing a Javadoc comment.	58

no/feide/moria/servlet/StatisticsHandler.java

Error		Line
	Line has trailing spaces.	34
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Line has trailing spaces.	40
	First sentence should end with a period.	41
	Line has trailing spaces.	47
	Method 'getAccumStatistics' is not designed for extension - needs to be abstract, final or empty.	48
	Missing a Javadoc comment.	48
	Method 'getNumStatisticsCollections' is not designed for extension - needs to be abstract, final or empty.	51
	Missing a Javadoc comment.	51
	Method 'getStatisticsCollection' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Line has trailing spaces.	57
	Method 'addIgnoreService' is not designed for extension - needs to be abstract, final or empty.	58
	Missing a Javadoc comment.	58
	Line has trailing spaces.	61
	Missing a Javadoc comment.	62
	Line has trailing spaces.	69
	Line has trailing spaces.	78
	Line has trailing spaces.	79
	Line has trailing spaces.	80
	Line has trailing spaces.	89
	Line has trailing spaces.	91
	Expected @param tag for 'namespaceURI'.	98
	Expected @param tag for 'sName'.	98
	Expected @param tag for 'qName'.	98
	Expected @param tag for 'attrs'.	98
	Expected @throws tag for 'SAXException'.	99
	'}' should be on the same line.	106
	'}' should be on the same line.	109
	Line has trailing spaces.	115
	Line has trailing spaces.	118
	Line has trailing spaces.	126
	'}' should be on the same line.	126
	Line has trailing spaces.	134
	Line has trailing spaces.	150
	'}' should be on the same line.	152
	Missing a Javadoc comment.	158
	Missing a Javadoc comment.	164
	Line has trailing spaces.	174
	Line has trailing spaces.	175
	Line has trailing spaces.	176

no/feide/moria/servlet/StatisticsMonth.java

Error		Line
	Line has trailing spaces.	25
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Line has trailing spaces.	33
	Missing a Javadoc comment.	34
	Line has trailing spaces.	36
	Method 'hashCode' is not designed for extension - needs to be abstract, final or empty.	38
	Missing a Javadoc comment.	38
	Method 'compareTo' is not designed for extension - needs to be abstract, final or empty.	42
	Missing a Javadoc comment.	42
	Parameter obj should be final.	42
	Method 'equals' is not designed for extension - needs to be abstract, final or empty.	46
	Missing a Javadoc comment.	46
	Parameter obj should be final.	46
	Method 'getMonthNum' is not designed for extension - needs to be abstract, final or empty.	50
	Missing a Javadoc comment.	50
	Method 'getMonthName' is not designed for extension - needs to be abstract, final or empty.	53
	Missing a Javadoc comment.	53
	Line has trailing spaces.	56
	Missing a Javadoc comment.	57

no/feide/moria/servlet/StatisticsServlet.java

Error		Line
	Unused import - javax.servlet.http.HttpServlet.	33
	Unused import - no.feide.moria.controller.MoriaController.	41
	Line has trailing spaces.	74
	Line has trailing spaces.	97
	Line has trailing spaces.	101
	'}' should be on the same line.	107
	Line has trailing spaces.	116
	Line has trailing spaces.	137
	Line has trailing spaces.	139
	Line has trailing spaces.	142
	Line has trailing spaces.	143
	'+' is not preceded with whitespace.	145
	Line has trailing spaces.	147
	Line is longer than 150 characters.	152
	Line has trailing spaces.	156
	Line contains a tab character.	157
	'cast' is not followed by whitespace.	158
	'while' is not followed by whitespace.	160
	Line has trailing spaces.	170
	Line has trailing spaces.	177
	Line has trailing spaces.	180
	'cast' is not followed by whitespace.	182
	Line has trailing spaces.	184
	'}' should be on the same line.	190
	Line is longer than 150 characters.	193
	'cast' is not followed by whitespace.	193
	')' is preceded with whitespace.	193
	Line has trailing spaces.	213
	Line has trailing spaces.	216
	Line has trailing spaces.	219
	Missing a Javadoc comment.	220
	Parameter out should be final.	220
	Parameter bundle should be final.	220
	Line has trailing spaces.	222
	Line has trailing spaces.	223
	Line has trailing spaces.	225
	Line has trailing spaces.	229
	Line has trailing spaces.	232
	Missing a Javadoc comment.	233
	Parameter out should be final.	233
	Parameter bundle should be final.	233
	Parameter filename should be final.	233
	Line has trailing spaces.	237
	'cast' is not followed by whitespace.	239
	'=' is not preceded with whitespace.	241
	'=' is not followed by whitespace.	241
	'<' is not preceded with whitespace.	241
	'<' is not followed by whitespace.	241
	Line has trailing spaces.	248
	Line has trailing spaces.	251
	'}' should be on the same line.	256
	Line has trailing spaces.	265
	Line has trailing spaces.	285
	Line has trailing spaces.	297
	Line has trailing spaces.	298
	'}' should be on the same line.	302
	Line has trailing spaces.	309
	Line has trailing spaces.	325

no/feide/moria/servlet/StatusServlet.java

Error		Line
	Unused import - no.feide.moria.store.MoriaStore.	52
	Unused import - no.feide.moria.store.MoriaStoreException.	53
	Unused import - no.feide.moria.store.MoriaStoreFactory.	54
	Line has trailing spaces.	79
	Line has trailing spaces.	81
	Line has trailing spaces.	94
	Line has trailing spaces.	99
	Line has trailing spaces.	103
	Line has trailing spaces.	104
	Line has trailing spaces.	109
	Expected an @return tag.	117
	Line has trailing spaces.	137
	Missing a Javadoc comment.	138
	Line has trailing spaces.	140
	First sentence should end with a period.	143
	Line has trailing spaces.	145
	Expected an @return tag.	149
	Parameter bundle should be final.	149
	Expected @param tag for 'bundle'.	149
	Line has trailing spaces.	175
	Line has trailing spaces.	177
	First sentence should end with a period.	178
	Line has trailing spaces.	180
	Expected an @return tag.	184
	Parameter bundle should be final.	184
	Expected @param tag for 'bundle'.	184
	Line has trailing spaces.	187
	Line has trailing spaces.	211
	Line has trailing spaces.	219
	Line has trailing spaces.	222
	Expected an @return tag.	226
	Parameter bundle should be final.	226
	Expected @param tag for 'bundle'.	226
	Line has trailing spaces.	227
	Line has trailing spaces.	229
	Line has trailing spaces.	233
	Line has trailing spaces.	239
	Line has trailing spaces.	240
	Line has trailing spaces.	249
	'catch' is not followed by whitespace.	250
	Line has trailing spaces.	257
	Line has trailing spaces.	260
	Method 'checkBackend' is not designed for extension - needs to be abstract, final or empty.	261
	Missing a Javadoc comment.	261
	Parameter bundle should be final.	261
	Line has trailing spaces.	262
	Line has trailing spaces.	264
	Method length is 156 lines (max allowed is 150).	294
	Line has trailing spaces.	297
	Line has trailing spaces.	302
	Line has trailing spaces.	322
	Line has trailing spaces.	324
	Line has trailing spaces.	327
	Line has trailing spaces.	328
	'+' is not preceded with whitespace.	330
	Line has trailing spaces.	332
	Line is longer than 150 characters.	337
	Line has trailing spaces.	341
	Line contains a tab character.	342
	'cast' is not followed by whitespace.	343
	'while' is not followed by whitespace.	345
	Line has trailing spaces.	355
	Line has trailing spaces.	362
	'>' is not preceded with whitespace.	369
	'>' is not followed by whitespace.	369
	'cast' is not followed by whitespace.	371
	Line has trailing spaces.	376
	Line is longer than 150 characters.	378
	Line has trailing spaces.	388
	Line has trailing spaces.	391
	Line has trailing spaces.	394
	Line has trailing spaces.	399
	Line has trailing spaces.	401
	Line has trailing spaces.	404
	Line has trailing spaces.	406
	Line has trailing spaces.	409
	Line has trailing spaces.	411
	'{' is not preceded with whitespace.	415
	Line has trailing spaces.	416
	Line has trailing spaces.	420
	Line has trailing spaces.	423
	Line has trailing spaces.	426
	Line has trailing spaces.	429
	Line has trailing spaces.	446
	Line has trailing spaces.	449
	Line has trailing spaces.	451
	'}' should be on the same line.	467
	Line has trailing spaces.	469
	Line has trailing spaces.	472

no/feide/moria/servlet/soap/AuthenticationFailedException.java

Error		Line
	File does not end with a newline.	0

no/feide/moria/servlet/soap/AuthenticationFailedException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Method 'getFaultstring' is not designed for extension - needs to be abstract, final or empty.	27
	Line has trailing spaces.	28
	Line has trailing spaces.	30

no/feide/moria/servlet/soap/AuthenticationUnavailableException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Line has trailing spaces.	6
	Line has trailing spaces.	12
	Line has trailing spaces.	18
	Line has trailing spaces.	20
	Line has trailing spaces.	22
	Line has trailing spaces.	23
	Method 'getFaultstring' is not designed for extension - needs to be abstract, final or empty.	29
	Line has trailing spaces.	30
	Line has trailing spaces.	32

no/feide/moria/servlet/soap/AuthorizationFailedException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Line has trailing spaces.	11
	Line has trailing spaces.	18
	Line has trailing spaces.	20
	Line has trailing spaces.	22
	Method 'getFaultstring' is not designed for extension - needs to be abstract, final or empty.	28
	Line has trailing spaces.	29
	Line has trailing spaces.	31

no/feide/moria/servlet/soap/ClientException.java

Error		Line
	File does not end with a newline.	0

no/feide/moria/servlet/soap/ClientException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	First sentence should end with a period.	3
	Method 'getFaultcode' is not designed for extension - needs to be abstract, final or empty.	29

no/feide/moria/servlet/soap/IllegalInputException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Line has trailing spaces.	11
	Line has trailing spaces.	12
	Line has trailing spaces.	18
	Line has trailing spaces.	20
	Line has trailing spaces.	22
	Method 'getFaultstring' is not designed for extension - needs to be abstract, final or empty.	28
	Line has trailing spaces.	29
	Line has trailing spaces.	31

no/feide/moria/servlet/soap/InternalException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Line has trailing spaces.	5
	Line has trailing spaces.	10
	Line has trailing spaces.	11
	Line has trailing spaces.	17
	Line has trailing spaces.	19
	Line has trailing spaces.	21
	Line has trailing spaces.	22
	Method 'getFaultstring' is not designed for extension - needs to be abstract, final or empty.	28
	Line has trailing spaces.	29
	Line has trailing spaces.	31

no/feide/moria/servlet/soap/SOAPException.java

Error		Line
	File does not end with a newline.	0

no/feide/moria/servlet/soap/SOAPException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Line has trailing spaces.	8
	Line has trailing spaces.	14
	Line has trailing spaces.	16

no/feide/moria/servlet/soap/ServerException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	First sentence should end with a period.	4
	Line has trailing spaces.	11
	Line has trailing spaces.	17
	Line has trailing spaces.	19
	Line has trailing spaces.	21
	Line has trailing spaces.	22
	Method 'getFaultcode' is not designed for extension - needs to be abstract, final or empty.	29

no/feide/moria/servlet/soap/SimpleAxisServlet.java

Error		Line
	Line has trailing spaces.	59
	Line has trailing spaces.	60
	Method length is 153 lines (max allowed is 150).	238
	Line has trailing spaces.	345
	'||' should be on a new line.	346
	Line has trailing spaces.	348
	Line has trailing spaces.	352
	Line has trailing spaces.	354
	Line is longer than 150 characters.	453
	Line is longer than 150 characters.	499

no/feide/moria/servlet/soap/UnknownTicketException.java

Error		Line
	Line does not match expected header line of '/*'.	1
	Line has trailing spaces.	11
	Line has trailing spaces.	12
	Line has trailing spaces.	18
	Line has trailing spaces.	20
	Line has trailing spaces.	22
	Method 'getFaultstring' is not designed for extension - needs to be abstract, final or empty.	28
	Line has trailing spaces.	29
	Line has trailing spaces.	31

no/feide/moria/servlet/soap/package.html

Error		Line
	Missing package documentation file.	0

no/feide/moria/webservices/v2_0/AuthenticationImpl.java

Error		Line
	Line has trailing spaces.	205
	Line has trailing spaces.	219

no/feide/moria/webservices/v2_1/AuthenticationImpl.java

Error		Line
	Line is longer than 150 characters.	92
	Line is longer than 150 characters.	105
	Line is longer than 150 characters.	110
	Line has trailing spaces.	282
	Line has trailing spaces.	285
	Line has trailing spaces.	297

no/feide/moria/webservices/v2_2/Attribute.java

Error		Line
	Line has trailing spaces.	80
	Line has trailing spaces.	81
	Line has trailing spaces.	87
	Line has trailing spaces.	89
	Line has trailing spaces.	113

no/feide/moria/webservices/v2_2/Authentication.java

Error		Line
	Line does not match expected header line of ' *'.	17

no/feide/moria/webservices/v2_2/AuthenticationImpl.java

Error		Line
	Line does not match expected header line of ' *'.	17
	Line is longer than 150 characters.	104
	Line is longer than 150 characters.	118
	Line is longer than 150 characters.	123
	Line has trailing spaces.	299
	Line has trailing spaces.	313
	'=' is not preceded with whitespace.	412
	'=' is not followed by whitespace.	412
	'<' is not preceded with whitespace.	412
	'<' is not followed by whitespace.	412
	'+' is not preceded with whitespace.	413
	'+' is not followed by whitespace.	413

no/feide/moria/webservices/v2_3/Authentication.java

Error		Line
	Line does not match expected header line of ' *'.	17

no/feide/moria/webservices/v2_3/AuthenticationImpl.java

Error		Line
	Line has trailing spaces.	50
	Line is longer than 150 characters.	90
	Line is longer than 150 characters.	104
	Line is longer than 150 characters.	109
	Line has trailing spaces.	285
	Line has trailing spaces.	299